+1
> On Oct 12, 2016, at 6:52 PM, Mandy Chung <mandy.ch...@oracle.com> wrote:
>
> Simple patch close the ClassFileReader with try-with-resource.
>
>
> diff --git a/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java
> b/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java
> --- a/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java
> +++ b/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java
> @@ -680,9 +680,9 @@
> private boolean genModuleInfo(JdepsConfiguration config) throws
> IOException {
> // check if any JAR file contains unnamed package
> for (String arg : inputArgs) {
> + try (ClassFileReader reader =
> ClassFileReader.newInstance(Paths.get(arg))) {
> Optional<String> classInUnnamedPackage =
> - ClassFileReader.newInstance(Paths.get(arg))
> - .entries().stream()
> + reader.entries().stream()
> .filter(n -> n.endsWith(".class"))
> .filter(cn -> toPackageName(cn).isEmpty())
> .findFirst();
> @@ -696,6 +696,7 @@
> return false;
> }
> }
> + }
>
> ModuleInfoBuilder builder
> = new ModuleInfoBuilder(config, inputArgs, options.genModuleInfo);
>
> Thanks
> Mandy
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
