Hi Amy,
Thanks for the suggestions. I will fix them in the next update.
I've had some issues with port in use errors and am looking for best
practices
in starting the servers and their cleanup.
Roger
On 10/20/2016 11:54 AM, Amy Lu wrote:
On 10/20/16 11:32 PM, Amy Lu wrote:
On 10/20/16 3:59 AM, Roger Riggs wrote:
The support in sun.reflect.ReflectionFactory for custom
serialization, such as IIOP input
and output streams, is being expanded beyond the necessary
constructor of a serializable
class to include access to the private methods readObject,
writeObject, readResolve,
writeReplace, etc.
The IIOP implementation is updated to use a combination of
ReflectionFactory and
Unsafe to serialize and deserialize objects and no longer rely on
setAccessible.
Tests are included for ReflectionFactory and the affected IIOP classes.
Please review and comment,
jdk repo webrev:
http://cr.openjdk.java.net/~rriggs/webrev-reflection-factory-8164908/
corba repo webrev :
http://cr.openjdk.java.net/~rriggs/webrev-reflection-factory-iiop-8164908/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8164908
Thanks, Roger
test/com/sun/corba/serialization/ObjectStreamTest.java
371 startOrbd_orig();
Should test wait for several seconds after this to make sure it started?
413 orbdProcess.destroy();
414 if (!orbdProcess.waitFor(10, TimeUnit.SECONDS)) {
And to try best to cleanup process and release port, how about use:
orbdProcess.destroyForcibly();
orbdProcess.waitFor();
Thanks,
Amy
(I'm not an official reviewer.)
Thanks,
Amy
