Hi all Please help with one more reviewer comment.
Regards Srinivasan Raghavan > On 19-Oct-2016, at 9:38 AM, Srinivasan Raghavan > <[email protected]> wrote: > > Thanks for the review. >> On 18-Oct-2016, at 4:16 PM, Chris Hegarty <[email protected]> wrote: >> >> >>> On 17 Oct 2016, at 09:51, Srinivasan Raghavan >>> <[email protected]> wrote: >>> >>> Hi all >>> >>> Please review the fix for the bug >>> >>> Bug :https://bugs.openjdk.java.net/browse/JDK-8075205 >>> >>> The tests uses classes directory for the output files. This can result in >>> the files being left over after the test is complete which can result in >>> instability. The tests copies the files to be compiled form test src to >>> test classes which can result in copy of permission and result in >>> instability because the test has delete operations. The test fails randomly >>> mostly in copy or delete operation. I propose the test to be refactored to >>> make the use scratch directory as its output directory and eliminate shell >>> by using testlibrary utils. >>> >>> fix : http://cr.openjdk.java.net/~sraghavan/8075205/webrev.00/ >> >> This looks good to me. Thanks Srinivasan. >> >> -Chris. >
