> On Oct 27, 2016, at 2:44 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > The updated comment in ClassLoaders might be a bit clearer if you drop "if > defined”. >
OK, dropped “if defined”. > A minor comment on the test is that it could use ProcessTools.executeTestJava > to avoid needing JAVA_TOOL. ProcessTools::executeTestJava launches the process inherited with CLASSPATH environment variable set. I can use ProcessTools::createJavaProcessBuilder that calls JDKToolFinder::getJDKTool to find the launcher instead of having the test finding the launcher (no difference anyway). I’m okay either way and updated the webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168205/webrev.01/ thanks Mandy
