Looks ok Amy. -Chris.
> On 10 Nov 2016, at 03:31, Amy Lu <amy...@oracle.com> wrote: > > Please review the patch to add com/sun/corba/cachedSocket to > exclusiveAccess.dirs so as tests won't run concurrently. > > This is to address one potential issue that corba tests (start and use orbd > service) may run into port conflict issue if run in concurrency. Most of such > tests are under javax/rmi and already in exclusiveAccess.dirs. Test > com/sun/corba/cachedSocket/7056731.sh also runs orbd and should not be run > concurrently. > > bug: https://bugs.openjdk.java.net/browse/JDK-8169041 > webrev: http://cr.openjdk.java.net/~amlu/8169041/webrev.00 > > Thanks, > Amy > > --- old/test/TEST.ROOT 2016-11-10 11:05:37.000000000 +0800 > +++ new/test/TEST.ROOT 2016-11-10 11:05:36.000000000 +0800 > @@ -18,7 +18,7 @@ > othervm.dirs=java/awt java/beans javax/accessibility javax/imageio > javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d > sun/pisces javax/xml/jaxp/testng/validation java/lang/ProcessHandle > # Tests that cannot run concurrently > -exclusiveAccess.dirs=java/rmi/Naming java/util/prefs > sun/management/jmxremote sun/tools/jstatd sun/security/mscapi > java/util/stream javax/rmi > +exclusiveAccess.dirs=java/rmi/Naming java/util/prefs > sun/management/jmxremote sun/tools/jstatd sun/security/mscapi > java/util/stream javax/rmi com/sun/corba/cachedSocket > # Group definitions > groups=TEST.groups [closed/TEST.groups] > >
