Yes. Stephen
On 16 November 2016 at 09:08, nadeesh tv <nadeesh...@oracle.com> wrote: > Hi Roger &Stephen, > > Could I push the webrev? > > http://cr.openjdk.java.net/~ntv/others/anubhav/webrev.01/ > > Thanks and regards, > Nadeesh > > > On 11/7/2016 6:05 PM, Anubhav Meena wrote: > > Thanks for the review! > > Here is the updated webrev > http://cr.openjdk.java.net/~ntv/others/anubhav/webrev.01/ > > -Anubhav > > > On Nov 2, 2016, at 4:04 PM, Stephen Colebourne <scolebou...@joda.org> wrote: > > I agree with Nadeesh, the updated code can still throw > DateTimeException from the call to getLong(). Unlike before, this > DateTimeException is desired. > > Stephen > > > On 28 October 2016 at 16:58, nadeesh tv <nadeesh...@oracle.com> wrote: > > > Hi Anubhav, > > > - * @throws DateTimeException if the field is not available and the > section is not optional > > > I think you should not remove the DTException since still there is a chance > of throwing DTE > Regards, > Nadeesh > > On 10/28/2016 12:18 AM, Anubhav Meena wrote: > > > Hi all, > > Please review. Please ignore last mail as links not working properly > there. > > Bug Id : https://bugs.openjdk.java.net/browse/JDK-8167618 > <https://bugs.openjdk.java.net/browse/JDK-8167618> > Issue: DateTimeFormatter.format() uses exceptions for flow control. > Webrev: http://cr.openjdk.java.net/~rchamyal/anmeena/8167618/webrev.00/ > <http://cr.openjdk.java.net/~rchamyal/anmeena/8167618/webrev.00/> > > > > -- > Thanks and Regards, > Nadeesh TV > > > > -- > Thanks and Regards, > Nadeesh TV >
