> On Nov 17, 2016, at 1:22 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 17/11/2016 20:03, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169909/webrev.00/ >> >> This fixes a regression that causes java agent fails to >> append to class path when the initial module on the module >> path but no class path. The AppClassLoader should have a >> URLClassPath instance set for the support of Java agent, >> Instrumentation::appendToSystemClassLoaderSearch. >> >> This patch also updates JavaClassPathTest to cover more test >> cases for JAR file and CLASS-PATH attribute. >> > This looks okay, I just wondering if the source for jdk.test in > java/lang/instrument/src should be moved down one directly level so that it's > clear which test this code is for.
Yes it would be clearer: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169909/webrev.01/ Mandy