On Thu, Nov 17, 2016 at 12:03 PM, Paul Sandoz <paul.san...@oracle.com>
wrote:
>
>
> SplittableRandom
> —
>
> 533 /**
> 534 * Generates a pseudorandom number with the indicated number of
> 535 * low-order bits. Because this class has no subclasses, this
> 536 * method cannot be invoked or overridden.
> 537 *
> 538 * @param bits random bits
> 539 * @return the next pseudorandom value from this random number
> 540 * generator's sequence
> 541 */
> 542 protected int next(int bits) {
> 543 return nextInt() >>> (32 - bits);
> 544 }
> 545
>
> Unless i am missing something really subtle, I don’t think this is
> required since SplittableRandom does not extend from Random (unlike in
> ThreadLocalRandom), and no associated reflective test is required.
>
Thanks! I completely missed that SplittableRandom doesn't extend Random!
Reverted changes to SplittableRandom and SplittableRandomTest.
I'm regenerating
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
but Paul's review version is available at
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration.2016-11-17/
