For what it's worth, this looks good to me too. :-) The name "mark" is a bit confusing, as are all the methods with the word "mark" in it; I have to think for a moment about what each of them do. Perhaps identifierStart would be better or something, along with setIdentifierStart()? Also, "skipIdentifier" is a bit confusing, perhaps that means advanceToNextIdentifier?
On Wed, Nov 30, 2016 at 6:41 AM, Claes Redestad <claes.redes...@oracle.com> wrote: > +1 > > Found a reference to getNext in a comment that should be removed, no > re-review required. > > /Claes > > > On 2016-11-30 12:36, Peter Levart wrote: > >> Here's a webrev incorporating both suggestions. All 73 java/jang/reflect >> jtreg tests are passing... >> >> http://cr.openjdk.java.net/~plevart/jdk9-dev/8035424_Signatu >> reParser.performance/webrev.03/ >> >> >> Regards, Peter >> > >
