> On Dec 2, 2016, at 6:29 AM, Claes Redestad <[email protected]> wrote:
>
> :
> http://cr.openjdk.java.net/~redestad/8170595/webrev.03/
>
> This brings significant improvements to some variants:
Good to see the significant improvements.
I think what isLocalOrAnonymousClass needs probably is something like this:
private boolean hasEnclosingMethodInfo() {
Object[] enclosingInfo = getEnclosingMethod0();
if (enclosingInfo != null) {
EnclosingMethodInfo.validate(enclosingInfo);
}
return enclosingInfo != null;
}
Then EnclosingMethodInfo doesn’t seem the need to change. The overall change
would be simpler.
As Joe suggests, this worths adding test cases for these methods, if not
present.
Mandy
