Hi Christoph, I ran this patch through our regression test suite against the NIO tests and it built and passed the test on all platforms (Linux, OS X, Solaris, Windows). So it’s +1 on the review.
Thanks, Brian On Dec 22, 2016, at 8:27 AM, Brian Burkhalter <[email protected]> wrote: > Hi Christoph, > > It looks OK, but have you built it on the other Unix platforms? If necessary > I could run it through our regression suite first. > > Thanks, > > Brian > > On Dec 22, 2016, at 7:58 AM, Langer, Christoph <[email protected]> > wrote: > >> no problem. So, may I consider this reviewed? >> >> From: Brian Burkhalter [mailto:[email protected]] >> Sorry about that. There seems to a surprising lack of consistency for this >> across the platforms.
