On 4/01/2017 12:03 PM, Mandy Chung wrote:

On Jan 3, 2017, at 5:23 PM, Paul Sandoz <paul.san...@oracle.com> wrote:


On 3 Jan 2017, at 15:59, Mandy Chung <mandy.ch...@oracle.com> wrote:

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8172215/webrev.00/

This fixes the regression caused by JDK-8168836 such that java -cp “” would be 
accepted. It’s surprise that no launcher test covering such test case.  Now 
it’s added in JavaClassPathTest.

This patch also renames the testlibrary ModuleSourceBuilder to ModuleInfoMaker 
as Alan suggested.


213     private static boolean isWindows = System.getProperty("os.name”)

Make it final and rename to IS_WINDOWS ?


Sure. Updated in place.

It isn't final. :)

Functional fix looks good.

Thanks,
David

Mandy

Reply via email to