> On 10 Jan 2017, at 08:25, Xueming Shen <xueming.s...@oracle.com> wrote: > > On 1/9/17, 5:39 PM, Mandy Chung wrote: >>> On Jan 9, 2017, at 5:28 PM, Xueming Shen <xueming.s...@oracle.com> >>> wrote: >>> >>> >>> http://cr.openjdk.java.net/~sherman/8172432/webrev/ >>> >>> >>> the method has been updated as Paul suggested, to only take the root >>> module-info.class >>> and correct versioned meta-inf/versions/n/module-info.class >>> >> Does it miss “/“ between n and module-info.class? It reads to me it would >> return true if the name is "META-INF/versions/9module-info.class”? > > good catch, the webrev has been updated to fix it #1882 > http://cr.openjdk.java.net/~sherman/8172432/webrev
Thank you Sherman. I think this is a really nice change. If I’m not mistaken, this change also resolves https://bugs.openjdk.java.net/browse/JDK-8165640, right ? -Chris.
