Thanks Roger!
-Joe
On 1/11/2017 10:38 AM, Roger Riggs wrote:
Hi Joe,
Thanks for the clarifications.
Looks good
Roger
On 1/10/2017 1:58 PM, huizhe wang wrote:
On 1/9/2017 2:17 PM, Roger Riggs wrote:
Hi Joe,
a few comments:
CatalogManager:
- line 58: "will /return /as no mapping is found";
Or is it describing the behavior of the CatalogResolver (which is
throw a CatalogException)?
(possible more than 1 place)
While waiting for spec approval, I've updated the webrev and added 3
tests in CatalogFileInputTest [1]: line 118 - 138.
[1]
http://cr.openjdk.java.net/~joehw/jdk9/8171243/webrev/test/javax/xml/jaxp/unittest/catalog/CatalogFileInputTest.java.html
Check the copyrights -> 2017 (JarUtils.java)
Updated all classes / tests.
in JAXWS repo:
- Options.java: line 786 - you could use URI[]::new instead of
creating a placeholder URI[0].
Updated both classes.
webrevs:
http://cr.openjdk.java.net/~joehw/jdk9/8171243/webrev/
http://cr.openjdk.java.net/~joehw/jdk9/8171243_jaxws/webrev/
Thanks,
Joe
Looks good, Roger
On 1/9/2017 12:38 PM, huizhe wang wrote:
Hi,
The current Catalog API accepts file paths or URIs in a form of
String to create Catalog or CatalogResolver in an effort to
maintain consistency with the old Catalog API and other existing
processors. However, that also introduced an ambiguity in the API,
which is unwanted for a new API in Java SE 9.
Please review the changes.
In jaxp repo:
http://cr.openjdk.java.net/~joehw/jdk9/8171243/webrev/
In jaxws repo:
http://cr.openjdk.java.net/~joehw/jdk9/8171243_jaxws/webrev/
JBS: https://bugs.openjdk.java.net/browse/JDK-8171243
Thanks,
Joe
