> On Jan 25, 2017, at 11:32 AM, Kumar Srinivasan > <kumar.x.sriniva...@oracle.com> wrote: > > > Hi Henry, > > I was somewhat surprised to see changes to launcher_LANG.properties, I usually > make the change in the english/default locale and allow the L1ON team to make > the > locale specific changes, but if you are confident of the changes, that is > fine. > > src/java.base/share/native/libjli/args.c > > + // Check if Main class specified after argument checked > + // Must be after expansion so we can caught if main class specified > @argfile > > > Is my interpretation accurate ? If so please reword it accordingly. > /* > * Check if main-class is specified after argument being checked, it > * must always appear after expansion, as a main-class specified in > * an @argfile is not allowed, and it must be caught now. > */
Not exactly, main-class or other terminal operation specified in the environment variable is not allowed, even if it is from @argfile. However, @argfile directly on command line has no such limitations. I’ll update accordingly. > > + assert (*env == '\0' || isspace(*env)); > > asserts are not enable in product builds, is the intention only > for debug builds ? Should this be flagged as a warning or something > under tracing ? > Yes, that’s what should happen if the code if implemented correctly regardless the input. > src/java.base/windows/native/libjli/cmdtoargs.c > > - // iterate through rest of coammand line > > + // iterate through rest of command line > Fixed. Cheers, Henry
