Hi Daniel, Thanks for the patch and uncover that Constructor::newInstance is not covered by SHOW_REFLECT_FRAMES.
The change looks okay. The javadoc of SHOW_REFLECT_FRAMES can be clarified to include Constructor::newInstance. As for the test, can you separate this in a new test to test showing and hiding reflecton frames and also getCallerClass? Mandy > On Feb 3, 2017, at 11:51 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi, > > Please find below a simple fix for: > > 8173898: StackWalker.walk throws InternalError if called > from a constructor invoked through reflection. > https://bugs.openjdk.java.net/browse/JDK-8173898 > > http://cr.openjdk.java.net/~dfuchs/webrev_8173898/webrev.00/ > > best regards, > > -- daniel
