> On 10 Feb 2017, at 13:01, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Feb 10, 2017, at 7:48 AM, Xueming Shen <xueming.s...@oracle.com> wrote: >> >> Hi, >> >> Please help review the changes for >> >> https://bugs.openjdk.java.net/browse/JDK-8165640 >> http://cr.openjdk.java.net/~sherman/8146486/webrev > > > 1781 sb.append("\n[").append(ename).append("]”); > 1786 sb.append("\n name ").append(md.toNameAndVersion()); > > We can make jar -d output similiar to `java —-list-modules` and have the > entry name next to the module name in the same line. > > module hi (module-info.class) > module hi (META-INF/versions/10/module-info.class) > > 1759-1763: an alternative is to use stream().sorted().foreach(…) that you > won’t need to create the names array. >
Yes, i prefer to stream approach too. (FWIW if Stream.toArray was used and performance was a concern that might motivate using a more imperative style). > Otherwise, looks okay. > +1 Paul.
