Re: [9] RFR 8177969: Faster FilePermission::implies by avoiding the use of Path::relativize

Fri, 07 Apr 2017 07:51:36 -0700 

Webrev updated at

   http://cr.openjdk.java.net/~weijun/8177969/webrev.01/

Changes since webrev.00 [1]

1. Copyright years.
2. Test fix. check() should include Windows drive tests like contains() does. 

Thanks
Max
[1] http://cr.openjdk.java.net/~weijun/8177969/webrev.01/interdiff.patch.html 

On 04/05/2017 10:13 PM, Roger Riggs wrote:

Hi Max,

The code looks ok.

How much faster does it make FilePermission compares?

I assume if it is not accepted to be fixed in JDK 9, you will push it to
JDK 10.

Roger


On 4/3/2017 11:30 AM, Weijun Wang wrote:

http://cr.openjdk.java.net/~weijun/8177969/webrev.00/

This new implementation of containsPath(Path,Path) uses the logic of
Path::relativize without directly calling it, which is much faster now.

Thanks
Max

Reply via email to