On Tuesday 25 April 2017 08:41 PM, Chris Hegarty wrote:
Vyom,
On 24 Apr 2017, at 10:15, Vyom Tewari <vyom.tew...@oracle.com> wrote:
Hi All,
Please review the simple doc fix.
Webrev : http://cr.openjdk.java.net/~vtewari/8178298/webrev0.0/index.html
Bugid : https://bugs.openjdk.java.net/browse/JDK-8178298
Note, this patch depends on "JDK-8178725".
This is confusing. The bug synopsis and description indicate that the guide,
jndi-ldap-gl.html, will be moved into the jdk repository as a doc-file, similar
to what happened in 8178101 [1], but your webrev clearly does not implement
this. It instead proposes to use the new extLink, as you have eluded to in the
email. If the latter, then the changes are ok, just update the bug details to
match what is being done.
Hi Chris thanks for review, when i created the issue, i did not knew the
approach how i am going to fix it.I will update the bug detail.
thanks,
Vyom
-Chris.
[1] https://bugs.openjdk.java.net/browse/JDK-8178101
