On 04/05/2017 22:14, Paul Sandoz wrote:
New update here:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html
<http://cr.openjdk.java.net/%7Epsandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html>
I accepted most comments directly. I shuffled around the paragraphs in
the modular jar section, partially in preparation for any changes and
further explanations for automatic modules.
This looks much better.
L85 adds the word "security" which I don't think was in the previous
iteration. Do mean the signature related files detailed in the "Signed
JAR File" section? If so then they apply to modular JAR files too. The
simplest might be to just drop the word "security" from the sentence.
L91-95 - This could link to ModuleFinder.of(Path...) so that it can
avoid the details as to how the module name and packages are derived.
L177 still has "A non-exported public or protected class". Did you
consider changing this to "A public or protected class in a non-exported
package"?
-Alan
