JoinLeave
—
29 * @build jdk.test.lib.NetworkConfiguration
is this line required?
BasicMulticastTests
—
210 NetworkInterface nif =
config.ip6MulticastInterfaces().iterator().next();
211 InetAddress anySource = config.ip4Addresses(nif).iterator().next();
212 membershipKeyTests(nif, ip4Group, anySource);
213 exceptionTests(nif);
214
215 // re-run the membership key tests with IPv6 if available
216
217 Iterator<NetworkInterface> iter =
config.ip6MulticastInterfaces().iterator();
218 if (iter.hasNext()) {
#210 should be ip4
Paul.
> On 19 May 2017, at 10:43, Igor Ignatyev <[email protected]> wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8180644/webrev.00/index.html
>> 698 lines changed: 287 ins; 376 del; 35 mod;
>
> Hi all,
>
> could you please review this patch which moves NetworkConfiguration class to
> the top level test library? there were two instances of NetworkConfiguration:
> one in jdk testlibrary, another in java/nio/channels/DatagramChannel. they
> are almost identical, the only significant difference is that *interfaces
> methods of the latter return only the interfaces which support multicast, the
> former has special methods for that. NetworkConfiguration has been moved to
> the top level library and the tests were updated accordingly.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8180644/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8180644
> testing: affected tests, :jdk_net, :jdk_nio
>
> Thanks,
> -- Igor
