> On May 19, 2017, at 4:29 PM, Igor Ignatyev <[email protected]> wrote: > > could you please review this small fix which moves ModuleInfoMaker class from > jdk testlibrary to the top level testlibrary? since ModuleInfoMaker depends > on CompilerUtil and thus on jdk.compiler module, it has been placed to > jdk.test.lib.compiler package to avoid unneeded module dependency in tests. > HashesTest has been updated to use ModuleInfoMaker::compile instead of using > CompilerUtils::compile directly. > > webrev: http://cr.openjdk.java.net/~iignatyev//8180724/webrev.00/index.html > jbs: https://bugs.openjdk.java.net/browse/JDK-8180724 > testing: affected tests (jdk/test/tools/launcher)
jdk/test/tools/jmod/hashes/HashesTest.java Nit: can you keep line 307-309, 386-387 unchanged? Otherwise, looks fine. Mandy
