Hi Max, thank you for the review.
it seems webrev fails to create a patch file when -f option is used. -- Igor > On May 30, 2017, at 5:54 PM, Weijun Wang <[email protected]> wrote: > > Hi Igor > > Your change looks fine. > > BTW, the http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/jdk10.patch > link is empty. Anything wrong with your version of webrev? > > Thanks > Max > > On 05/31/2017 08:40 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html >>> 354 lines changed: 148 ins; 149 del; 57 mod; >> Hi all, >> could you please review this changeset which moves JarUtils to the top level >> testlibrary? >> webrev: http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html >> jbs: https://bugs.openjdk.java.net/browse/JDK-8180888 >> testing: :tier[1-3] >> Thanks, >> -- Igor
