Looks fine to me. Thank you for clarification. ----- huaming...@oracle.com wrote:
> Ping. > > Thank you > > -Hamlin > > > On 2017/5/31 8:13, Hamlin Li wrote: > > Hi Alan, Sergey, > > > > Sorry for delayed reply, I have been on vacation for last few days. > > > > I do have a tool (still under development, it's based on javadoc > > doclet) to scan versions (currently from 1.7 to 9) of jdk source, > find > > since tag issues, and give suggested since tag versions if feasible. > > > But for older versions of jdk source code, for example 1.6 or older > > > versions, the tool has trouble with them, so for classes added in > > older versions, the tool can only detect the issues, but can not > give > > the suggested since tag versions, the changes in this webrev is > > generated manually. As for older versions, we only need to fix > issues > > once, so I think it's worth to do the necessary manual check and > fix. > > > > Thank you > > > > -Hamlin > > > > > > On 2017/5/27 14:17, Alan Bateman wrote: > >> > >> > >> On 27/05/2017 02:14, Hamlin Li wrote: > >>> Is someone available to review the change? > >>> > >> I skimmed through it, crossing checking several against the docs > for > >> JDK 1.0, JDK 1.1, and JDK 1.2. I didn't spot any mistakes but I > agree > >> with Sergey, it would be good to know if this was done by creating > > >> the lists from the binaries rather than manual. > >> > >> -Alan > >> > >>> > >>> > >>> On 2017/5/25 17:19, Hamlin Li wrote: > >>>> Would you please review below patch? > >>>> > >>>> bug: https://bugs.openjdk.java.net/browse/JDK-8181082 > >>>> > >>>> webrev: http://cr.openjdk.java.net/~mli/8181082/webrev.00/ > >>>> > >>>> > >>>> Thank you > >>>> > >>>> -Hamlin > >>>> > >>> > >> > >
