On 12/06/2017 07:09, Igor Ignatyev wrote:
Hi Alan,

I've filed https://bugs.openjdk.java.net/browse/JDK-8181915 to clean up w/ this mess w/ dependencies in testlibrary classes.

just to double check, can I consider this fix and the fixes for tier1[1-2], tier3[3-4] reviewed by you?

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048199.html [2] http://cr.openjdk.java.net/~iignatyev//8181759/webrev.02/index.html <http://cr.openjdk.java.net/%7Eiignatyev//8181759/webrev.02/index.html> [3] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048165.html [4] http://cr.openjdk.java.net/~iignatyev//8181762/webrev.00/index.html <http://cr.openjdk.java.net/%7Eiignatyev//8181762/webrev.00/index.html>

For now, yes, I think these are okay. As part of the clean-up then it would be good to update FileUtils to not use Platform and that would avoid needing to build jdk.test.lib.Platform in several of these tests.

-Alan

Reply via email to