On 14/06/2017 18:20, Paul Sandoz wrote:
On 12 Jun 2017, at 01:00, Hamlin Li <huaming...@oracle.com> wrote:
Would you please review the below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8181478
webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/
It took me a few moments to grok the NonExistentDriver behaviour. If i got it
correct, this is checking that deleteOnExit is working correctly?
If so it might be clearer to make this is a separate test that is run as a
driver and a test with different arguments performing the action and then the
checking.
I agree. Also in FileOpenTest then it can use APIs to set the hidden
attribute, no need to launch attrib.exe each time.
-Alan