> On Jul 25, 2017, at 5:29 PM, Andrey Nazarov <[email protected]>
> wrote:
>
> Thanks, Mandy
> I’ve updated patch
> http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/
> <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/>
>
Thanks for the update.
One suggestion: you could simply change line 133 to
compiler = java.util.spi.ToolProvider.findFirst("javac”).orElse(null);
Or, no need for saving the compiler but instead have getCompiler() to return:
return java.util.spi.ToolProvider.findFirst("javac”).orElseThrow(() ->
throw new RuntimeException(“javac not found”));
Mandy
> —Andrei
>> On 25 Jul 2017, at 16:12, Mandy Chung <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>
>>> On Jul 21, 2017, at 6:35 PM, Andrey Nazarov <[email protected]
>>> <mailto:[email protected]>> wrote:
>>>
>>> Hi,
>>>
>>> Please review changes in launcher tests. I’ve added absent @modules jtreg
>>> tags.
>>>
>>> Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/
>>> <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/>
>>> <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/
>>> <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/>>
>>
>> A few tests only require java.compiler but not jdk.compiler. Maybe
>> TestHelper should be updated to use java.util.spi.ToolProvider to find
>> “javac” to avoid the dependency to java.compiler if no compiler is needed.
>>
>> test/tools/launcher/modules/upgrademodulepath/UpgradeModulePathTest.java
>> - can you keep @modules list in alphabetical order.
>>
>> Mandy
>
