Update: addresses Stuart's comment for String.split

Webrev: http://cr.openjdk.java.net/~jjg/8186052/webrev.01/index.html
API: http://cr.openjdk.java.net/~jjg/8186052/api.01/index.html

-- Jon

On 08/09/2017 06:28 PM, Stuart Marks wrote:
On 8/9/17 5:11 PM, Jonathan Gibbons wrote:
Please review this proposed change to address accessibility and HTML issues
in the java.base java.lang[.*] packages.

In general, the changes consist of
* update tables to add scope=row|col as appropriate.
    In some cases, slightly more surgery was needed on the table
* fix issues reported by tidy
    In most cases, this is removing superfluous <p> elements.

Webrev: http://cr.openjdk.java.net/~jjg/8186052/webrev.00/index.html
API: http://cr.openjdk.java.net/~jjg/8186052/api.00/index.html

Hi Jon,

These changes look good. In most cases the table surgery was a big improvement. One small quibble I have is with the table in String.split(regex, limit). The limit column has numbers, and the alignment changed from centered to left-aligned, neither of which is really very good. I'd suggest changing this column to be right-aligned, so the negative values in this column will be aligned appropriately.

Thanks,

s'marks

Reply via email to