+1

Naoto

On 8/25/17 10:03 AM, Brent Christian wrote:
Hi,

Please review this simple doc fix for:

https://bugs.openjdk.java.net/browse/JDK-8186217

When working on JDK-8029891, solutions were sought to avoid cluttering up the Properties JavaDoc with new overridden methods. The @hidden tag was considered, then later rejected.

Here[1] is the email where I state that I've removed the @hidden tags from my patch.

But this[2] one managed to sneak in.  D'oh!

It should be removed:

diff -r 46e9f2b0a472 src/java.base/share/classes/java/util/Properties.java
--- a/src/java.base/share/classes/java/util/Properties.java    Wed Aug 23 10:58:11 2017 -0700 +++ b/src/java.base/share/classes/java/util/Properties.java    Fri Aug 25 09:50:00 2017 -0700
@@ -1345,7 +1345,6 @@
          return map.remove(key, value);
      }

-    /** @hidden */
      @Override
     public synchronized boolean replace(Object key, Object oldValue, Object newValue) {
          return map.replace(key, oldValue, newValue);


Thanks!
-Brent

1. http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-May/041204.html

2. http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/40dec428648e/src/java.base/share/classes/java/util/Properties.java#l1348

Reply via email to