Sigh.
The bad news is that I accidentally committed and pushed the changes for
this issue
(JDK-8186946) before they had been approved, along with the changes for
JDK-8186947,
which had been approved.
The good news is that I had already addressed and verified Mandy's comments
regarding broken links. So the net result is that the source code in the
repo is
good, but the metadata for these two issues is a bit messed up. I'll
update the
JBS bugs to document this.
If anyone should find any additional issues in this review, I will of
course address
them and file an additional bug if necessary.
-- Jon
On 09/01/2017 01:34 PM, Jonathan Gibbons wrote:
Please review these changes to address accessibility and other minor
issues in
the API docs for the java.xml.bind module.
JBS: https://bugs.openjdk.java.net/browse/JDK-8186946
Webrev: http://cr.openjdk.java.net/~jjg/8186946/webrev
API:
http://cr.openjdk.java.net/~jjg/8186946/api/java.xml.bind-summary.html
-- Jon
Notes on the changes follow:
src/java.xml.bind/share/classes/javax/xml/bind/JAXBPermission.java
Convert file to use the standard "striped" pattern for tables
src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java
Fix broken links that arise when relative links are inherited into
the docs for subtypes
src/java.xml.bind/share/classes/javax/xml/bind/Unmarshaller.java
Convert file to use the standard "striped" pattern for tables
Fix broken links that arise when relative links are inherited into
the docs for subtypes
src/java.xml.bind/share/classes/javax/xml/bind/annotation/XmlNsForm.java
Convert file to use the standard "striped" pattern for tables
src/java.xml.bind/share/classes/javax/xml/bind/annotation/XmlType.java
Convert file to use the standard "striped" pattern for tables
src/java.xml.bind/share/classes/javax/xml/bind/annotation/adapters/package-info.java
Remove redundant <p> tags
src/java.xml.bind/share/classes/javax/xml/bind/annotation/package.html
Convert file to use the standard "striped" pattern for tables
Replace nested layout tables with simple lists
src/java.xml.bind/share/classes/javax/xml/bind/attachment/AttachmentUnmarshaller.java
Convert file to use the standard "striped" pattern for tables
src/java.xml.bind/share/classes/javax/xml/bind/helpers/package-info.java
Remove redundant <p> tags
src/java.xml.bind/share/classes/javax/xml/bind/util/package-info.java
Remove redundant <p> tags
The following files are removed, since they are shadowed by the
corresponding package-info.java
files:
src/java.xml.bind/share/classes/javax/xml/bind/annotation/adapters/package.html
src/java.xml.bind/share/classes/javax/xml/bind/helpers/package.html
src/java.xml.bind/share/classes/javax/xml/bind/util/package.html
-- Jon
