Hi,
I had a suggestion to use fdo and fd parameter names and to fix
copyright dates.
http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/
Thanks, Roger
On 9/19/2017 10:52 AM, Brian Burkhalter wrote:
Hi Roger,
On Sep 19, 2017, at 6:51 AM, Roger Riggs <roger.ri...@oracle.com
<mailto:roger.ri...@oracle.com>> wrote:
The updated webrev is:
http://cr.openjdk.java.net/~rriggs/webrev-fd-refactor-8187631-02/
I avoided cluttering the initial webrev with misc cleanup.
This looks good. The name “rawfd” is good. It could equally well be
named “nativefd” but that’s being picky.
I renamed the parameters, corrected some old <code></code> markup and
reordered
the declarations so a side-by side diff of the Unix and Windows
FileDescriptor.java files
makes it easy to see the necessary differences.
All good.
