On Mon, Nov 6, 2017 at 5:33 PM, David Holmes <david.hol...@oracle.com> wrote:
> On 7/11/2017 8:17 AM, Martin Buchholz wrote: > >> Thanks for the review! >> >> On Mon, Nov 6, 2017 at 1:36 PM, David Holmes <david.hol...@oracle.com >> <mailto:david.hol...@oracle.com>> wrote: >> >> >> 8189764: Miscellaneous changes imported from jsr166 CVS 2017-11 >> >> >> All seem okay. Though I'm curious about the changes from >> "catch(Throwable" to "catch(Exception" ? >> >> >> There's a half-hearted attempt to appease >> http://errorprone.info/bugpattern/TryFailThrowable >> No actual bugs were fixed. >> > > Hmmm. Not sure I see a problem if threadUnexpectedException just wraps and > rethrows the original exception. On the other hand Errors are no longer > being handled this way. Probably doesn't make a difference either way. > Yes, probably doesn't make a difference either way. These TryFailThrowable <http://errorprone.info/bugpattern/TryFailThrowable> warnings just don't have enough value, so they are all reverted back to catch (Throwable).
