JShell changes — The code change is fine.
The help change in the properties file is not consistent with the other items, note: --help-extra, -X Print help on… so this should be: —help, -h, -? Or, if there is a tool-wide standard, then the —help-extra entry should be changed. The tests of “—help” should be updated to include the now documented “-h” and “-?” As Jon noted, the _ja and _zh_CN properties should not be touched. -Robert > On Nov 17, 2017, at 3:23 AM, Lindenmaier, Goetz <goetz.lindenma...@sap.com> > wrote: > > Hi, > > please review this change. I also filed a CSR for this: > http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8189102 > CSR: https://bugs.openjdk.java.net/browse/JDK-8191477 > > See the webrev for a detailed description of the changes. > > If required, I'll make break-out changes to be reviewed separately. > > I had posted a RFR before, but improved the change to > give a more complete overview of currently supported flags > for the CSR: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-October/028615.html > > Best regards, > Goetz. >