On 11/21/17 12:41 PM, Brent Christian wrote:
Hi,

Please review my change to this small bit of ClassLoader spec that can be tidied up, as noticed by Martin.

Issue:
https://bugs.openjdk.java.net/browse/JDK-8191173
Webrev:
http://cr.openjdk.java.net/~bchristi/8191173/webrev.00/

In java.lang.ClassLoader these methods:
  getParent()
  getPlatformClassLoader()
  getSystemClassLoader()
all state that the returned classloader is, "for delegation."

For getParent() this makes sense to mention.  But it seems unnecessary for the other two methods, which are static, and designed to always return the indicated classloader.  The getSystemClassLoader() docs go on to immediately mention that the system classloader is the default delegation parent.

Looks good.

As Alan points out, the parent class loader is only used for delegation when that class loader follows the delegation model.  The getParent method as well as the constructors could be made clear but I would leave it as is.

Mandy

Reply via email to