> On 27 Nov 2017, at 20:19, Martin Buchholz <marti...@google.com> wrote: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html > > <http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html> > > Thanks to Dávid Karnok and Pavel Rappo for help with SubmissionPublisher. > > 8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods > throw > 8187947: A race condition in SubmissionPublisher
Hard to review by eyeballing code but it looks good to me. SubmissionPublisher -- 1004 // Order-sensitive field declarations Is this still relevant with the use of @Contended on the demand/waiting fields of BufferedSubscription and periodic updates? 81 * <p>A single SubmissionPublisher may be shared among multiple 82 * sources. Actions in a source thread prior to publishing an item or 83 * issuing a signal <a href="package-summary.html#MemoryVisibility"> 84 * <i>happen-before</i></a> actions subsequent to the corresponding 85 * access by each subscriber. But reported estimates of lag and demand 86 * are designed for use in monitoring, not for synchronization 87 * control, and may reflect stale or inaccurate views of progress. We probably need a CSR for this. Is “corresponding access by each subscriber” referring to access of the published item by each subscriber? Paul. > 8191069: Miscellaneous changes imported from jsr166 CVS 2017-12
