> On 15 Dec 2017, at 13:01, David Lloyd <david.ll...@redhat.com> wrote: > > I'm not a reviewer, but I was curious about this change; unfortunately > the diff seems to be dominated by case and formatting changes making > the actual functional aspect change hard to divine. >
If not already i recommend viewing via udiffs, i find that makes it easier. > Within the JBoss unit we have an informal policy that formatting > changes should be presented separately so that it's easier to trace > back problems in the future, as well as being much easier to review > the change in the first place. Would I be stepping out of bounds to > suggest that this change should be similarly divided? > In hindsight :-) at this point i would prefer not to split it unless reviewers are having a really hard time. I was furiously hacking on this and got fed up with the names making it harder for me to reason about the code so i changed ‘em mid-flight when doing this work. Thanks, Paul.
