Hi, this webrev adds a real test case for javapackager. I also removed unused variable dontExecuteWithWrongFlags. http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.03/
Feel free to use this change (webrev03) or http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/ with the pure fix for this issue. Best regards, Goetz. > -----Original Message----- > From: Lindenmaier, Goetz > Sent: Donnerstag, 18. Januar 2018 17:25 > To: 'Lindenmaier, Goetz' <goetz.lindenma...@sap.com>; Weijun Wang > <weijun.w...@oracle.com> > Cc: jdk-...@openjdk.java.net; core-libs-dev@openjdk.java.net > Subject: RE: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails > with java.lang.AssertionError: HelpFlagsTest failed: > > Posting this to core-libs-dev. > > Please review > http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/ > which excludes the Oracle proprietary tools from the test. > I can not verify this. > > Best regards, > Goetz. > > > > -----Original Message----- > > From: jdk-dev [mailto:jdk-dev-boun...@openjdk.java.net] On Behalf Of > > Lindenmaier, Goetz > > Sent: Donnerstag, 18. Januar 2018 17:02 > > To: Weijun Wang <weijun.w...@oracle.com> > > Cc: jdk-...@openjdk.java.net > > Subject: RE: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails > > with java.lang.AssertionError: HelpFlagsTest failed: > > > > Hi, > > > > Added ssvagent: > > http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/ > > > > Best regards, > > Goetz. > > > > > -----Original Message----- > > > From: Weijun Wang [mailto:weijun.w...@oracle.com] > > > Sent: Donnerstag, 18. Januar 2018 16:44 > > > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > > > Cc: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; jdk- > > > d...@openjdk.java.net > > > Subject: Re: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails > > > with java.lang.AssertionError: HelpFlagsTest failed: > > > > > > On Windows, there is also a ssvagent.exe. > > > > > > > On Jan 18, 2018, at 11:37 PM, Lindenmaier, Goetz > > > <goetz.lindenma...@sap.com> wrote: > > > > > > > > Hi, > > > > > > > > the most simple fix is to just exclude the four tools: > > > > http://cr.openjdk.java.net/~goetz/wr18/8195663- > > fixHelpTest/webrev.01/ > > > > Unfortunately I can't test this, as my build does not contain these > > > > tools. > > > > > > > > If somebody tells me how to build these tools, I will adapt > > > > the test to check them, and eventually adapt the tools to > > > > CSR 8191477 https://bugs.openjdk.java.net/browse/JDK-8191477. > > > > > > > > What list should this be reviewed on? I just posted to jdk-dev for now. > > > > > > > > Best regards, > > > > Goetz.
