On 14 March 2018 at 23:55, Stuart Marks <stuart.ma...@oracle.com> wrote: > So, how about we define trimLeft, trimRight, and trimWhitespace > all in terms of Character.isWhitespace?
This seems like a reasonable approach. I'd expect tab to be trimmed for example. Commons-Lang is a good source to consider when looking at naming. https://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/StringUtils.html Rather than re-using "trim", commons-lang uses "strip". So you have strip(), stripLeft() and stripRight(). If you want to stick with "trim", how about trimAll() instead of trimWhitespace(). Shorter and more obvious I think. Otherwise, I think you'd need trimWhitespaceLeft() and trimWhitespaceRight() to match. In line with these whitespace methods, I'd like to see isBlank() added, could also be named isWhitespace(). The existing isEmpty() method is fine, but a lot of the time user input validation routines want to base their decision on "empty once trimmed". str.isBlank() would be the same as str.trimAll().isEmpty() but without the object creation. Finally, a constant for EMPTY has always been missing from java.lang.String. It would be great to add it. Stephen
