Combining the reformatting and test additions makes the patch more difficult to review. The net effect seems to be adding the following directories to the exclusiveAccess.dirs list:

  44     sun/management/jmxremote \
  45     sun/rmi \
  46     sun/security/mscapi \
  47     sun/tools/jstatd

Is that correct?

Please characterize the number of tests added to the list and the expected performance impact on the tier 3 test group.

Thanks,

-Joe


On 4/23/2018 11:47 AM, Paul Sandoz wrote:
Hi Hamlin,

Do you have a sense of what rmi tests are problematic to run concurrently? 
Maybe you can subset to reduce the increased impact on execution time?

Paul.

On Apr 20, 2018, at 12:21 AM, Hamlin Li <huaming...@oracle.com> wrote:

Is someone available to review the following patch?

Thank you

-Hamlin


On 19/04/2018 4:17 PM, Hamlin Li wrote:
would you please review the following patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8201469

http://cr.openjdk.java.net/~mli/8201469/webrev.00/

( For othervm.dirs property, I just reformat it. )


In my test result, with jtreg option "-concurrency:4", after apply the patch, 
tier3 tests on different platforms will be slower about 1.5~2.0 times than before.
I think stability of tests are more important than executing time, how do you 
think about it?

Thank you
-Hamlin

Reply via email to