On 26/04/2018 01:45, Brian Burkhalter wrote:
On Apr 25, 2018, at 5:38 PM, Brian Burkhalter <[email protected]>
wrote:
The attached patch changed the behavior to use the content of the environment
variable TMPDIR, if present. Note that this does not change where the hsperf*
folders are created.
The source change looks OK to me aside from the copyright year and that in the
second line here
Note that I am only saying that the patch looks OK, not that we want to use it.
There have been a number of issues filed in this area over time, for example
https://bugs.openjdk.java.net/browse/JDK-6205979. There are arguments against
this change.
Right, it's come a few times. In principle it seems reasonable but it
will likely have a tail of issues. One concern is that it will cause
issues with the attach mechanism as that depends on the tool side
knowing the target VM's tmp dir. There's also the transition issue where
old JDKs will be using /tmp, new JDKs using whatever TMPDIR is set too.
This is one of these issues where most of the work will be shaking out
the knock on impact (that will be needed for the CSR and release note at
least).
-Alan
