Re: RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so)

[Aleksey Shipilev]

On 05/15/2018 06:11 PM, Severin Gehwolf wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8203223
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203223/webrev.01/

*) Um:
  assert(seed > 0 && "invariant");

This should be this, right?

  assert(seed > 0, "invariant");

*) I would also write:

  return (s4)s & 0x7FFFFFFF;

as

  return (s4)(s & 0x7FFFFFFF);

-Aleksey