Hi Joe, Looks fine overall
Perhaps remove the commented out line of code on line 76 in StAXSourceTest.java before pushing Best Lance > On May 15, 2018, at 1:00 PM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Hi, > > Please review a fix that adds better tolerance for a XMLStreamReader > reporting no attribute type, in which case, the default CDATA type is used. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8202426 > webrevs: http://cr.openjdk.java.net/~joehw/jdk11/8202426/webrev/ > > Thanks, > Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
