Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

[David Holmes]

Hi Mandy,

On 23/05/2018 10:56 AM, mandy chung wrote:


On 5/22/18 3:15 AM, David Holmes wrote:
Here are the updates so far in response to all the review comments.

Incremental webrev: 
http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v2-incr/ 


Full webrev: 
http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v2/

thanks for the update.  Looks good in general.

Thanks for continuing to work through it!

SampleNest.java

   33     static List<Class<?>> _nestedTypes = new LinkedList<Class<?>>();

This can use the diamond expression i.e. new LinkedList<>().

Ok.

TestReflectionAPI.java

Thanks for covering many test cases.

  263                 Class<?>[] memberSet =
  264                     new 
HashSet<Class<?>>(Arrays.asList(members)).toArray(new Class<?>[0]);

It can be simplified using Stream:

    Class<?>[] memberSet = Arrays.stream(members).toArray(Class<?>[]::new);

I'm not very stream literate :)

Will make the suggested changes for v3 (once I've processed hotspot v2 
stuff).

Thanks,
David

Mandy