Hi,
An updated webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/
A webrev showing changes from the previous revision is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/
The changes are:
-updated src/jdk.internal.le/share/legal/jline.md
-the problem with automatically adding space after completion is resolved
-a few tweaks to tests
Does this look good?
Thanks,
Jan
On 29.5.2018 16:04, Jan Lahoda wrote:
Hi,
On 29.5.2018 14:51, Alan Bateman wrote:
On 25/05/2018 21:20, Jan Lahoda wrote:
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to
2.14.6.
The complete webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
To simplify reviewing, there is:
-an antipatch that removes the JDK-specific changes and restores the
vanilla 2.12.1 content:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
-a patch that replaces the 2.12.1 content with 2.14.6:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
-a patch that re-applies the JDK-specific changes (like including
adjusting packages, and removal/commenting out of usage of features
that would require undesirable dependencies, and any changes that had
to be done to other modules):
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.
Thanks.
Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.
Yes, it should, I forgot to do that. I'll send an update later.
Jan
-Alan
