Hi Matthias,

in line 527, where the actual output is done, I think you would need to replace 
variable 'message' with 'outputMessage', otherwise I guess it won't compile??

Also, mapFileName can't be used at this place, because it has already been 
free'ed there.

But in general the additions make sense and will make it easier to find issues 
in the tzmappings file.

Best regards
Christoph

From: Baesken, Matthias
Sent: Donnerstag, 7. Juni 2018 13:35
To: [email protected]
Cc: Langer, Christoph <[email protected]>; Lindenmaier, Goetz 
<[email protected]>
Subject: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi, could you please  review this small  change that improves  the error 
messages in  matchJavaTZ .
A reason of the failure is added to the message , and also  the offset where 
the error happened .


Bug :

https://bugs.openjdk.java.net/browse/JDK-8204539


Webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8204539/


Thanks, Matthias

Reply via email to