Thanks Naoto, Roger for the review. Made the suggested changes and
pushed to the repo.
Regards,
Nishit Jain
On 21-06-2018 00:23, Roger Riggs wrote:
Hi Nishit,
Looks ok
My only comment would be to put the relative path to the
language-subtag-registry.txt in a private static final constant
to call attention to the dependency on the source layout instead of
burying it in the code.
$.02, Roger
On 6/20/2018 2:27 PM, naoto.s...@oracle.com wrote:
Looks good.
Naoto
On 6/20/18 3:32 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8204938
Bug: https://bugs.openjdk.java.net/browse/JDK-8204938
Webrev: http://cr.openjdk.java.net/~nishjain/8204938/webrev.02/
Fix: Added a test case to cross check the LSR data generated for the
JDK APIs. So, for each lsr data update, the test case need not be
updated, it automatically cross checks the updated lsr data.
Regards,
Nishit Jain
