Looks good.
Naoto
On 6/25/18 12:37 AM, Dora Zhou wrote:
Hi Naoto,
Thanks a lot for the review.
I have made suggested changes, Kindly have a look at:
http://cr.openjdk.java.net/~ljiang/8194152/webrev.01/
<http://cr.openjdk.java.net/%7Eljiang/8194152/webrev.01/>
Regards,
Dora
From: naoto.s...@oracle.com
To: dan.z.z...@oracle.com, i18n-...@openjdk.java.net,
core-libs-dev@openjdk.java.net, security-...@openjdk.java.net
Sent: Saturday, June 23, 2018 1:23:50 AM GMT +08:00 Beijing /
Chongqing / Hong Kong / Urumqi
Subject: Re: <i18n dev> [11]RFR 8194152:
sun/security/tools/jarsigner/AltProvider.java failed on de-DE locale
Hi Dora,
You could move those two lines that sets the locale to en-US before the
for-loop, so that if "args" contains -J-Duser.language/country then it
can override the default en-US.
The JIRA issue needs noreg-self label.
Naoto
On 6/22/18 1:26 AM, Dora Zhou wrote:
Hello,
Please help review the fix for JDK-8194152. Thank you.
The test compares output with expected error messages in English, set
locale to en-US so that the output are not translated into other
languages.
Bug: https://bugs.openjdk.java.net/browse/JDK-8194152
Webrev: http://cr.openjdk.java.net/~ljiang/8194152/webrev/
<http://cr.openjdk.java.net/%7Eljiang/8194152/webrev/>
Regards,
Dora
