On 07/07/2018 00:46, Xueming Shen wrote:
Hi
Please help review the changeset for JDK-8206389
issue: https://bugs.openjdk.java.net/browse/JDK-8206389
webrev: http://cr.openjdk.java.net/~sherman/8206389/webrev
Cause: ZipOutputStream.writeCEN().writeCEN() incorrectly calculate the
length
of bytes needed for theĀ "unix timestamps" when the "last modified
time" is
NOT set.
The updated webrev looks okay to me, just a minor nit that "elem +=5" is
missing a space. A suggestion to avoid repeating the comment is to bump
elem by 5, then += 4 when there is a mtime.
-Alan