The change looks fine.
Btw, do you guy have better implementation for these two charsets? These two
were left untouched when I did the reimplementation back to 6/7. Did not
have time to figure out its mapping table (especially the compatibility
concern
when dealing with the mapping hard-coded inside the source and those maps
from cdc repository). This was the main reason I did not move the
SimpleEUCEncoder
into the sun.nio.cs.DoubleByte.java.
-Sherman
On 5/19/18, 12:56 AM, Nasser Ebrahim wrote:
Hello,
With the following three bugs, all the default locale charsets except two
(Vi_VN.IBM-1129& ja_JP.IBM-eucJP) are fixed for AIX platform.
- JDK-8201540: [AIX] Extend the set of supported charsets in java.base
- JDK-8202329: Codepage mappings for IBM-943 and Big5 (aix)
-
http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053050.html
: [AIX] Add charset IBM-964 (default charset for zh_TW.IBM-eucTW) to stdcs
[bug not yet opened].
For those fixed charsets, the charsets were existing in the extended
charsets (jdk.charsets) and they were not working with default locale
charset as it did not exist in the standard charset (java.base). The
charsets correspond to the two pending locale (Vi_VN.IBM-1129&
ja_JP.IBM-eucJP) does not exist in the jdk. They need to be added to the
extended charsets before adding to stdcs on AIX platform.
Here, am including the patch to fix the charset IBM-1129 for the locale
Vi_VN.IBM-1129. We are working on the other missing charset (for
ja_JP.IBM-eucJP) which will be contributed in some time.
The webrev of the fix is available at
http://cr.openjdk.java.net/~aleonard/IBM1129/webrev.00/
Kindly request you to open a bug and review the fix. Please let me know if
you have any questions.
Thank you,
Nasser Ebrahim
