Thank you, Mandy Regards, Chris
> On 28 Jul 2018, at 12:02 AM, mandy chung <mandy.ch...@oracle.com> wrote: > > Looks fine. This test uses JarUtils instead of jar tool and so > it does not depend on jdk.jar. > > Mandy > > On 7/27/18 1:42 AM, Chris Yin wrote: >> Please review below minor change to add missing module dependencies >> declaration, thanks >> bug: https://bugs.openjdk.java.net/browse/JDK-8208363 Changes: >> diff -r 65fc31d1042b test/jdk/java/lang/Package/PackageFromManifest.java >> --- a/test/jdk/java/lang/Package/PackageFromManifest.java Thu Jul 26 >> 16:22:58 2018 -0700 >> +++ b/test/jdk/java/lang/Package/PackageFromManifest.java Fri Jul 27 >> 15:46:34 2018 +0800 >> @@ -29,6 +29,7 @@ >> * same package if multiple jars). Then verify package versioning >> info >> * @library /lib/testlibrary >> * @library /test/lib >> + * @modules jdk.compiler >> * @run main PackageFromManifest setup test >> * @run main PackageFromManifest runJar test1.jar >> * @run main PackageFromManifest runJar test1.jar test2.jar foo.Foo1 >> Regards, >> Chris
